Update developer docs to ensure compatibility with latest scikit-learn. #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #319 +/- ##
=======================================
Coverage 80.00% 80.00%
=======================================
Files 24 24
Lines 2221 2221
Branches 411 411
=======================================
Hits 1777 1777
Misses 312 312
Partials 132 132 ☔ View full report in Codecov by Sentry. |
adam2392
approved these changes
Aug 28, 2024
|
Thanks @ryanhausen ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #314
What does this implement/fix? Explain your changes.
This addresses an issue that can happen if the neurodata/scikit-learn branch of scikit-learn is not compatable with the current stable release of scikit-learn, which can cause tests in treeple to fail.
Any other comments?